feat: Implemented Tagged Strings support#1
Open
crossi704 wants to merge 2 commits intodignifiedquire:tagsfrom
Open
feat: Implemented Tagged Strings support#1crossi704 wants to merge 2 commits intodignifiedquire:tagsfrom
crossi704 wants to merge 2 commits intodignifiedquire:tagsfrom
Conversation
Owner
dignifiedquire
left a comment
dignifiedquire
left a comment
There was a problem hiding this comment.
Nice, happy to include this, could you please add a test for it, and some doc comments with an example?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A contribution to String tag support in Serdes.
Rust lacks specialization support yet, therefore type implementation must be done from within the library.
According to Concise Binary Object Representation (CBOR)
CBOR URI (CBOR type 32) must be represented as a UTF-8 String with tag 32.
The changes done in this pull request allows one to successfully represent it by using the following code:
Example:
CBOR playground
32("example")
D8 20 # tag(32)
67 # text(7)
6578616D706C65 # "example"